can anyone tell me if this looks ok

note: the m and f stand for the male of female plugs on the molex splitter and which of the black wires do i connect the positive wire to cos thers 2 of them

The resistor should be on the long lead of the led(s) that goes to the +12v or +5v, NOT the ground. The red wire is the +5V, the yellow wire is the +12V, & the black wires are the ground. The resistor should be the right one for the voltage you want to use. If there are 2 connections on the switch then that's fine, but if there are 3 then the red wire from the led's should be moved accross to the left by one connection.

Your diagram is right. The resistor can be on the ground. Make sure you're using the right ohms and wattage resistor.

Can the resistor really be on the ground!?!?!? I never knew that..

p.s. SICKdimension should be a mod